feat(apollo-wind): add Core/HC editor themes and expand Code Editors patterns page#772
Open
1980computer wants to merge 5 commits into
Open
feat(apollo-wind): add Core/HC editor themes and expand Code Editors patterns page#7721980computer wants to merge 5 commits into
1980computer wants to merge 5 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
Pull request overview
This PR completes the token-based theming for the CodeBlock component’s future-dark and future-light variants by replacing remaining hardcoded hex colors with semantic CSS custom properties, aligning these themes with how Apollo Wind’s semantic tokens are intended to adapt across theme definitions.
Changes:
- Updated
future-darktheme colors (headerBg,labelColor,iconColor,lineNumberColor) to use semantic CSS variables. - Updated
future-lighttheme colors similarly, including switchingheaderBgto--surface-overlayto ensure header/body separation.
7bf506c to
4bc30df
Compare
4bc30df to
805c054
Compare
f20ed45 to
5f7aed8
Compare
5f7aed8 to
c184c3b
Compare
bea8f52 to
936dd79
Compare
de02d9e to
75e32bf
Compare
75e32bf to
7288543
Compare
7288543 to
d75227e
Compare
d75227e to
c7df4bd
Compare
1980computer
commented
Jun 17, 2026
1980computer
left a comment
Collaborator
Author
There was a problem hiding this comment.
All Copilot comments addressed in the latest push. Ready for re-review.
c7df4bd to
6890f9b
Compare
6890f9b to
b7e3265
Compare
b7e3265 to
8d78161
Compare
8d78161 to
2f3fae9
Compare
2f3fae9 to
fb216a9
Compare
…patterns page - Add Monaco and CodeMirror theme objects for all 6 Apollo themes (future-dark, future-light, dark, light, dark-hc, light-hc) — each is a static extraction of existing Apollo semantic tokens, no new colors introduced - Export all 12 new theme objects from @uipath/apollo-wind/editor-themes - Rewrite Code Editors stories with 3 usage patterns per editor (Full, Compact, Input toggle) and live previews for all theme variants on the Themes page Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fb216a9 to
4b07837
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR has two parts:
1. New editor theme objects for Monaco and CodeMirror
Packages all six Apollo theme variants as static hex objects that Monaco and CodeMirror can consume at registration time. No new colors — these are direct extractions of existing Apollo semantic CSS tokens from
theme-variables.css.New exports from
@uipath/apollo-wind/editor-themes:apolloCoreDarkMonaco✨apolloCoreDarkCodeMirror✨apolloCoreLightMonaco✨apolloCoreLightCodeMirror✨apolloCoreDarkHCMonaco✨apolloCoreDarkHCCodeMirror✨apolloCoreLightHCMonaco✨apolloCoreLightHCCodeMirror✨apolloFutureDarkMonaco(existing)apolloFutureDarkCodeMirror(existing)apolloFutureLightMonaco(existing)apolloFutureLightCodeMirror(existing)Also completes the CSS custom property integration for
future-darkandfuture-lightCodeBlock themes — all five chrome values now pull from Apollo design tokens.Type rename:
ApolloFutureCodeMirrorTheme→ApolloCodeMirrorTheme— the type is shared across all theme families so the "Future" qualifier was misleading.Package notes:
peerDependencies—editor-themesexports are pure data objects with no runtime importsdefineThemecalls across multiple editor instanceseditorThemeConfigsentries (e.g.apolloCoreDarkHCMonaco) — no string derivation that could produce wrong namesmonaco.tsandcodemirror.tsto reflect all three theme families (Future, Core, Core HC)2. Expanded Code Editors patterns page in Storybook
Replaces the minimal CodeBlock story with a full documentation section under Patterns → Code Editors. Renamed to
code-editors.stories.tsx.StaticMonacoPreviewalongside a live CodeMirror preview, plus a collapsible Token reference panel with syntax/UI color swatches and a ready-to-copy import snippet (with correct export names andimport * as monacoline)Test plan
http://localhost:6007→ Patterns → Code EditorsapolloCoreDarkHCMonaco/apolloCoreDarkHCCodeMirrorand import snippet includesimport * as monaco from 'monaco-editor'🤖 Generated with Claude Code